-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sender#sendUserNotification #107
Comments
Okay, I did a bit of digging. According to an answer on StackOverflow and accompanying blog post, the correct field to contain the notification key is simply The URL is also, according to the blog post, the same as used for regular messages. This makes implementation trivial. |
Yes, seems like the sending part is easy. |
I kind of want v0.10 out before we start considering user notifications (v0.11). But if it doesn't seem like too big a task, we could probably fit #108 (creating notification keys) in v0.11, too. |
Sure, go ahead! |
The only difference between a regular notification and a user notification is that the user notification uses the notification key to find its recipients (source):
It would be pretty straight forward to implement a
Sender#sendUserNotification
method. At the same time, this would be cause for generalizing a bunch of the code used inSender#send
.We should probably add
Sender#sendUserNotificationNoRetry
as well.The job of creating notification keys can be left out for now. It seems to me that it is immediately most relevant to handle on the client side (source), but I am open for discussion on this.
The text was updated successfully, but these errors were encountered: