Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Way to Turn Passcode Off Using TOPasscodeSettingsViewController #9

Open
inPhilly opened this issue Nov 12, 2017 · 1 comment

Comments

@inPhilly
Copy link

  • [X ] I have read this issue template and provided all possible information.
  • [X ] I'm NOT using CocoaPods

Hardware / Software

Which version of the library were you using?0.0.1
Which version of iOS are you running?several in simulator
What model of iOS device were you testing on?several in simulator
If using CocoaPods, which version of CocoaPods are you on?N/A

Goals

What is the outcome result you want to achieve with this library? Passcode controller in my app

Expected Results

A TOPasscodeSettingsViewState option to turn passcode off

Actual Results

It seems like, as of now, the TOPasscodeSettingsViewController can only be used to turn passcode on or change passcode. Usually, it is required that a user confirm a passcode before setting it off, and I could not see a way to easily do that with the controller as-is.

These are the current allowable states:
typedef NS_ENUM(NSInteger, TOPasscodeSettingsViewState) {
TOPasscodeSettingsViewStateEnterCurrentPasscode,
TOPasscodeSettingsViewStateEnterNewPasscode,
TOPasscodeSettingsViewStateConfirmNewPasscode
};

Feature Request

Add a way to turn passcode off, after confirmation of current passcode, using TOPasscodeSettingsViewController.

@TimOliver
Copy link
Owner

Sounds good! I'll probably have to implement this by the time I get around to integrating it into my own app, but if anyone else needs it before then, a PR would be greatly appreciated. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants