Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Posible improvements #16

Open
2 tasks done
lukeleleh opened this issue Dec 14, 2017 · 1 comment
Open
2 tasks done

Posible improvements #16

lukeleleh opened this issue Dec 14, 2017 · 1 comment

Comments

@lukeleleh
Copy link

  • I have read this issue template and provided all possible information.
  • I'm using CocoaPods and have run pod update before filing this issue.

Hardware / Software

Which version of the library were you using? 0.0.1
Which version of iOS are you running? iOS 11
What model of iOS device were you testing on? iPhone 8
If using CocoaPods, which version of CocoaPods are you on? 1.3.1

Goals

What is the outcome result you want to achieve with this library?

Provide the possibility to lock an app.

Expected Results

What did you expect to happen?

A) Provide a cancel button in TOPasscodeSettingsViewController. It could be an optional like rightAccessoryButton in TOPasscodeViewController.
B) Provide a property to hide the options button in TOPasscodeSettingsViewController to limit the passcodeType.
C) A way to change the text from views for translation.

Actual Results

What happened instead? (Please attach a screenshot/screen recording if possible)

Steps to Reproduce

What are the steps needed to reproduce this issue?
If this bug was caused by a specific image, please post it here.

It's not a bug 😄.

Thank you for this great library!

@TimOliver
Copy link
Owner

Thanks for the issue @luka888! I'm glad you're enjoying the library!

Yeah! Those suggestions sound good! I doubt they'd be very hard to add. If you or anyone else would like to add it in a PR, I'd really appreciate it. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants