New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing takewhile #8

Open

Tadaboody opened this issue Nov 29, 2018 · 0 comments

Labels

smell

Owner

Tadaboody commented Nov 29, 2018 •

edited

Loading

New smell

Smelly code

for x in seq:
    if pred(x):
        break
    # Body

Fixed code

from itertools import takewhile # If not already imported
for x in takewhile(seq,pred):
    # Body

Tadaboody added the smell label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment