New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use with open instead of manually opening and closing file handler #53

Open

Tadaboody opened this issue Jan 1, 2019 · 0 comments

Labels

new smell

Owner

Tadaboody commented Jan 1, 2019

New smell

Smelly code

fp = open(path,args,kwargs)
# Body
fp.close

Fixed code

with open(path,args,kwargs as fp:
    # Body

Why is it smelly?

Without a context manager you need to manually close the file, which is eror-prone.

Tadaboody added smell new labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment