Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use SIGKILL or SIGTERM for killing, not SIGABRT #169

Open
BenWiederhake opened this issue Oct 24, 2016 · 0 comments
Open

Use SIGKILL or SIGTERM for killing, not SIGABRT #169

BenWiederhake opened this issue Oct 24, 2016 · 0 comments

Comments

@BenWiederhake
Copy link

spectrum2 uses SIGABRT to kill child processes at least in NetworkPluginServer.cpp.

This makes it very non-obvious to figure out what happened, because SIGABRT usually comes from a program-internal call to abort(), which usually comes from a failing assert(), which meant that #146 and vysheng/tgl#116 (comment) were quite an adventure, whereas SIGKILL would have immediately conveyed what is happening.

Please use SIGKILL (9) or SIGTERM (15) for this.

I won't open an issue for this discussion about timeouts (both tgp and spectrum2), so if anyone cares, open an additional issue for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant