Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Commands #15

Open
Snowiiii opened this issue Aug 4, 2024 · 10 comments
Open

Add Commands #15

Snowiiii opened this issue Aug 4, 2024 · 10 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@Snowiiii
Copy link
Owner

Snowiiii commented Aug 4, 2024

Our goal is to implement all Vanilla Commands. Im sure this will take a while :D

Command Senders

  • Players can send Commands
  • Console can send Commands
  • RCON can send Commands

Commands

Custom

  • /pumpkin | gives information about current pumpkin version

Vanilla

https://minecraft.fandom.com/wiki/Commands

Config

  • Option to Enable or Disable every single Command, We may so should use the config to set the permission
@Snowiiii Snowiiii added this to Pumpkin Aug 4, 2024
@Snowiiii Snowiiii self-assigned this Aug 4, 2024
@Snowiiii Snowiiii converted this from a draft issue Aug 4, 2024
@Snowiiii Snowiiii moved this from Todo to In Progress in Pumpkin Aug 4, 2024
@Snowiiii Snowiiii added the enhancement New feature or request label Aug 4, 2024
@Snowiiii Snowiiii moved this from In Progress to Todo in Pumpkin Aug 4, 2024
@Snowiiii Snowiiii moved this from Todo to In Progress in Pumpkin Aug 4, 2024
@Snowiiii Snowiiii added this to the First Release milestone Aug 5, 2024
@Snowiiii Snowiiii added the good first issue Good for newcomers label Aug 5, 2024
@user622628252416
Copy link
Contributor

Hi!
As far as I can tell there is no command parser yet? Minecraft uses Brigadier (which is MIT licensed, but in Java ofc), would you appreciate if I reimplemented that in rust?

@Snowiiii
Copy link
Owner Author

Hi! As far as I can tell there is no command parser yet? Minecraft uses Brigadier (which is MIT licensed, but in Java ofc), would you appreciate if I reimplemented that in rust?

Hey, Yeah i actually had such an idea aswell, Would be great when you can do that. Feel free to use custom concepts you don't have to exactly match Brigadier

@user622628252416
Copy link
Contributor

user622628252416 commented Aug 17, 2024

Nvm, I just found this existing rust port. What's your policy on using external crates such as this one?

@Snowiiii
Copy link
Owner Author

Snowiiii commented Aug 17, 2024

Nvm, I just found this existing rust port. What's your policy on using external crates such as this one?

Hey, The crate is unmaintend, And i also would like to use an own solution

@user622628252416
Copy link
Contributor

I see. I'll have a look at what I can do

@Snowiiii Snowiiii removed this from the First Release milestone Sep 6, 2024
@Wundero
Copy link

Wundero commented Oct 16, 2024

Something to note for the command parser is that 1.21 introduced the @n selector for targetting the nearest entity that matches the selector. For players, it is equivalent to @p, but will matter when commands which target non-player entities are introduced later on.

Reference documentation for target selectors: https://minecraft.wiki/w/Target_selectors

@OfficialKris
Copy link
Contributor

Are we implementing only JE commands? This list includes commands not found in JE.

@glitchy-sk8k9
Copy link

Are we implementing only JE commands? This list includes commands not found in JE.

I see /ability in the list, that's BE. Probably so, maybe we will get completely different commands.

@Snowiiii
Copy link
Owner Author

Are we implementing only JE commands? This list includes commands not found in JE.

I see /ability in the list, that's BE. Probably so, maybe we will get completely different commands.

You right, I removed it since we only want to support Java Commands.
at least for now

@glitchy-sk8k9
Copy link

glitchy-sk8k9 commented Dec 12, 2024

Are we implementing only JE commands? This list includes commands not found in JE.

I see /ability in the list, that's BE. Probably so, maybe we will get completely different commands.

You right, I removed it since we only want to support Java Commands. at least for now

rip, also you're*

@Snowiiii Snowiiii pinned this issue Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
Status: In Progress
Development

No branches or pull requests

5 participants