Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Healthcheck Page #3432

Open
romainruaud opened this issue Nov 4, 2024 · 1 comment
Open

Healthcheck Page #3432

romainruaud opened this issue Nov 4, 2024 · 1 comment
Assignees
Labels

Comments

@romainruaud
Copy link
Collaborator

romainruaud commented Nov 4, 2024

We need a page dedicated to healthchecks.

This page should be accessible under the ElasticSuite > Healthcheck link in the menu.

The page is a simple grid (maybe try to do a nice html table with styles a bit nicer than the Magento ones).

The grid should be fed with an object named \Smile\ElasticsuiteCore\Healthcheck\List

This object should contains an array of \Smile\ElasticsuiteCore\Healthcheck\CheckInterface that can be injected via the DI.

The CheckInterface should have these methods :

  • getIdentifier() : return the check identifier (internal identifier)

  • getDescription() : return the check description

  • getStatus() : a closed-list of status : 'success', 'warning', 'error'

  • getSortOrder() : the sort-order of the check, to be able to display them in a defined order

For now, you can implement your two existing warning messages (ghost indices, and number of shards), as healthchecks.

We will implement more healthchecks (number of virtual categories, tracking events properly indexed, etc...) later.

@rbayet
Copy link
Collaborator

rbayet commented Nov 12, 2024

@vahonc Please add a "isVisible" in the interface, which will return a boolean.
By default, all checks have isVisible = true.
And only show isVisible = true checks in the grid.

vahonc added a commit to vahonc/elasticsuite that referenced this issue Nov 25, 2024
vahonc added a commit to vahonc/elasticsuite that referenced this issue Nov 25, 2024
vahonc added a commit to vahonc/elasticsuite that referenced this issue Nov 25, 2024
vahonc added a commit to vahonc/elasticsuite that referenced this issue Nov 25, 2024
vahonc added a commit to vahonc/elasticsuite that referenced this issue Dec 19, 2024
vahonc added a commit to vahonc/elasticsuite that referenced this issue Dec 19, 2024
vahonc added a commit to vahonc/elasticsuite that referenced this issue Dec 19, 2024
vahonc added a commit to vahonc/elasticsuite that referenced this issue Dec 19, 2024
vahonc added a commit to vahonc/elasticsuite that referenced this issue Dec 19, 2024
vahonc added a commit to vahonc/elasticsuite that referenced this issue Dec 19, 2024
vahonc added a commit to vahonc/elasticsuite that referenced this issue Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants