Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RowSettings highlight property doesn't support Indication09 - Indication20 #4119

Open
harelyshau opened this issue Sep 4, 2024 · 3 comments

Comments

@harelyshau
Copy link

harelyshau commented Sep 4, 2024

OpenUI5 version:
1.127 (latest)

Browser/version (+device/version): doesn't metter

Any other tested browsers/devices(OK/FAIL):

URL (minimal example if possible): https://openui5.hana.ondemand.com/entity/sap.ui.table.Table/sample/sap.ui.table.sample.Basic/code

User/password (if required and possible - do not post any confidential information here):

Steps to reproduce the problem:

  1. Go to this sample:
    https://openui5.hana.ondemand.com/entity/sap.ui.table.Table/sample/sap.ui.table.sample.Basic/code
  2. Provide RowSeettings with Indication09 - Indication20
image
  1. As a result it's not applied to a table
image But Indications 01-08 works well image

What is the expected result?
Provided indication color applied for highlighting row

What happens instead?
Nothing. Rows stays without highlighting

Any other information? (attach screenshot if possible)

@kskondov kskondov self-assigned this Sep 5, 2024
@kskondov kskondov removed their assignment Sep 5, 2024
@kskondov
Copy link
Contributor

kskondov commented Sep 5, 2024

Hello @harelyshau ,
Thank you for sharing this finding. I've created an internal incident DINC0259193. The status of the issue will be updated here in GitHub.
Regards,
Konstantin

@simlin
Copy link
Contributor

simlin commented Sep 23, 2024

CPOUIFTEAMB-2427

@simlin
Copy link
Contributor

simlin commented Sep 23, 2024

Hello @harelyshau ,
I discussed this with our design department. The additional colors were introduced for the inverted ObjectStatus use case, unfortunately without recognizing the table use case.
We will extend the support for the colors 9-10 as part of our backlog. The colors 11-20 do not fulfill the accessibility contrast requirements in the context of the list and tables and should therefore not be used in combination with the row highlight. The docu will be updated accordingly with the same backlog.
Best Regards
Jens

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants