Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'validateSuccessfulResponse' shouldn't a part of result<T: DataResponseSerializerProtocol> method #191

Open
bigMOTOR opened this issue Oct 26, 2020 · 0 comments · Fixed by #192
Open

'validateSuccessfulResponse' shouldn't a part of result<T: DataResponseSerializerProtocol> method #191

bigMOTOR opened this issue Oct 26, 2020 · 0 comments · Fixed by #192
Assignees
@bigMOTOR

Comments

@bigMOTOR
Copy link
Contributor

bigMOTOR commented Oct 26, 2020 •
edited
Loading

validateSuccessfulResponse shouldn't be a part of result<T: DataResponseSerializerProtocol> method. This lefts no room for function composition like runRequest -> validate -> getResult. Current way it fires implicit validation error validate(statusCode: 200..<300) no matter if I have my own function in validate.
I see having validateSuccessfulResponse inside result as a violation of the separation of concern principle.
@bigMOTOR bigMOTOR self-assigned this Oct 26, 2020
bigMOTOR added a commit that referenced this issue Nov 1, 2020
@bigMOTOR
Fix Issue #191. Reinstatement the separation of concern principle - r…
dc690ec 
…emove call of validateSuccessfulResponse from result<T: DataResponseSerializerProtocol> method.

#191
@bigMOTOR bigMOTOR mentioned this issue Nov 1, 2020
Merged
@bigMOTOR bigMOTOR linked a pull request Nov 1, 2020 that will close this issue
Fix Issue #191. Remove call of validateSuccessfulResponse from result<T: DataResponseSerializerProtocol> method. #trivial #192
Merged
rynecheow pushed a commit that referenced this issue Nov 20, 2020
@bigMOTOR
feat: Validate successful response made non-default behavior on request
6ec9800 
#191
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bigMOTOR bigMOTOR

Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@bigMOTOR