Drupal 9 compatibility for BAT/BEE

[cecrs]

Issue Key: BAT-154
Issue Type: New Feature
Created: 24/Jun/20 12:34 AM
Updated: 25/Jun/20 11:22 PM
Resolved:
Description: Please spend some time and test bat & bee with drupal 9 and make any changes necessary while retaining compatibility with d8.8. We don't need a 9.x branch, cf. https://www.drupal.org/docs/updating-drupal/how-to-prepare-your-drupal-7-or-8-site-for-drupal-9/preparing-drupalorg
Comment1: 24/Jun/20 4:49 PM;557058:5618d454-7c12-49db-afc2-962184518c4f;[https://www.drupal.org/project/services/issues/3154535|https://www.drupal.org/project/services/issues/3154535]
Comment2: 25/Jun/20 11:22 PM;557058:6023b735-a9a1-4569-8ba5-19759f061283;[~accountid:557058:5618d454-7c12-49db-afc2-962184518c4f] I got BEE installed on a d9 test site, and was able to enable a content type for BEE bookings. (hourly) When I visit the node page, the calendar does not work, and I get this error:

{noformat}Error: Call to undefined method Drupal\services\Controller\Services::entityManager() in Drupal\services\Controller\Services->processRequest() (line 47 of /var/www/drupalvm/web/modules/contrib/services/src/Controller/Services.php)
#0 [internal function]: Drupal\services\Controller\Services->processRequest(Object(Symfony\Component\HttpFoundation\Request), Object(Drupal\Core\Routing\RouteMatch), 'bat_api', 'unit_index:cale...')
#1 /var/www/drupalvm/web/core/lib/Drupal/Core/EventSubscriber/EarlyRenderingControllerWrapperSubscriber.php(123): call_user_func_array(Array, Array)
#2 /var/www/drupalvm/web/core/lib/Drupal/Core/Render/Renderer.php(573): Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber{closure}()
#3 /var/www/drupalvm/web/core/lib/Drupal/Core/EventSubscriber/EarlyRenderingControllerWrapperSubscriber.php(124): Drupal\Core\Render\Renderer->executeInRenderContext(Object(Drupal\Core\Render\RenderContext), Object(Closure))
#4 /var/www/drupalvm/web/core/lib/Drupal/Core/EventSubscriber/EarlyRenderingControllerWrapperSubscriber.php(97): Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext(Array, Array)
#5 /var/www/drupalvm/vendor/symfony/http-kernel/HttpKernel.php(158): Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber{closure}()
#6 /var/www/drupalvm/vendor/symfony/http-kernel/HttpKernel.php(80): Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object(Symfony\Component\HttpFoundation\Request), 1)
#7 /var/www/drupalvm/web/modules/contrib/bat_api/src/StackMiddleware/BatApiMiddleware.php(42): Symfony\Component\HttpKernel\HttpKernel->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true)
#8 /var/www/drupalvm/web/core/lib/Drupal/Core/StackMiddleware/Session.php(57): Drupal\bat_api\StackMiddleware\BatApiMiddleware->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true)
#9 /var/www/drupalvm/web/core/lib/Drupal/Core/StackMiddleware/KernelPreHandle.php(47): Drupal\Core\StackMiddleware\Session->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true)
#10 /var/www/drupalvm/web/core/modules/page_cache/src/StackMiddleware/PageCache.php(106): Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true)
#11 /var/www/drupalvm/web/core/modules/page_cache/src/StackMiddleware/PageCache.php(85): Drupal\page_cache\StackMiddleware\PageCache->pass(Object(Symfony\Component\HttpFoundation\Request), 1, true)
#12 /var/www/drupalvm/web/modules/contrib/services/src/StackMiddleware/FormatSetter.php(44): Drupal\page_cache\StackMiddleware\PageCache->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true)
#13 /var/www/drupalvm/web/core/lib/Drupal/Core/StackMiddleware/ReverseProxyMiddleware.php(47): Drupal\services\StackMiddleware\FormatSetter->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true)
#14 /var/www/drupalvm/web/core/lib/Drupal/Core/StackMiddleware/NegotiationMiddleware.php(52): Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true)
#15 /var/www/drupalvm/vendor/stack/builder/src/Stack/StackedHttpKernel.php(23): Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true)
#16 /var/www/drupalvm/web/core/lib/Drupal/Core/DrupalKernel.php(705): Stack\StackedHttpKernel->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true)
#17 /var/www/drupalvm/web/index.php(19): Drupal\Core\DrupalKernel->handle(Object(Symfony\Component\HttpFoundation\Request))
#18 {main}
{noformat}

If I go to /node/1/add-reservation, I get this error:

{noformat}Symfony\Component\DependencyInjection\Exception\ServiceNotFoundException: You have requested a non-existent service "commerce_cart.cart_manager". in Drupal\Component\DependencyInjection\Container->get() (line 151 of /var/www/drupalvm/web/core/lib/Drupal/Component/DependencyInjection/Container.php).
{noformat}
Comment3: