Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Very large file size for module #54

Open
JohannRosenberg opened this issue Aug 21, 2018 · 1 comment
Open

Very large file size for module #54

JohannRosenberg opened this issue Aug 21, 2018 · 1 comment

Comments

@JohannRosenberg
Copy link

JohannRosenberg commented Aug 21, 2018

I noticed that when I included your picker in my app, the file size went up by 100 mb which is a huge amount. After investigating, I discovered that your app was using the dependency emoji-js which in turn has the dependency emoji-datasource. I removed both of these from my app and your emoji picker worked fine without it. Can you explain why those dependencies are needed? What will I be losing if I leave them out?

@kadosa
Copy link

kadosa commented Dec 19, 2018

@JohannBlake I know I'm late to the party, but from what I can tell emoji-js is used to convert emojis to background images for those platforms that cannot render them using the sheets mentioned in the README. You're probably running on OSX hence for you removing these dependencies made no difference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants