Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openShiftUtils parameters' names are not unified across functions #73

Open
lina-is-here opened this issue Apr 22, 2020 · 1 comment
Open

Comments

@lina-is-here
Copy link

https://github.com/RedHatInsights/insights-pipeline-lib/blob/master/vars/openShiftUtils.groovy

Examples:

def withNode(Map parameters = [:], Closure body) {
...
def jenkinsSlaveImage = parameters.get('jenkinsSlaveImage', getDefaultSlaveImage(cloud))
def withUINode(Map parameters = [:], Closure body) {
...
def slaveImage = parameters.get('slaveImage', getDefaultSlaveImage(cloud))

def withJnlpNode(Map parameters = [:], Closure body) {
...
def image = parameters.get('image', getDefaultSlaveImage(cloud))

So in 3 functions the same thing is called 3 different names: jenkinsSlaveImage, slaveImage and image.

I think it would be better to unify them to one name.

@bsquizz
Copy link
Collaborator

bsquizz commented Apr 22, 2020

I agree this is confusing... I think we could standardize on 'slaveImage' but I would probably want to leave the old param names in place so we don't break anyone's existing pipelines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants