Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add to official base16 scheme list #27

Open
augustebaum opened this issue Oct 7, 2021 · 5 comments · May be fixed by chriskempson/base16-templates-source#120
Open

Add to official base16 scheme list #27

augustebaum opened this issue Oct 7, 2021 · 5 comments · May be fixed by chriskempson/base16-templates-source#120

Comments

@augustebaum
Copy link

Hi,

If it's not already in the plans, consider adding this to the list of schemes.

Nice work!

@RRethy
Copy link
Owner

RRethy commented Oct 7, 2021

I'm not sure we would be allowed since this repo doesn't actually follow some of their guidelines. The repo name and the fact we don't look at the terminals 16 colours are the main areas we break their guidelines.

@augustebaum
Copy link
Author

Is this something you intend to work towards? Otherwise, would forking be acceptable?

@RRethy
Copy link
Owner

RRethy commented Oct 8, 2021

I'm open to PRs to add 16 terminal colour support, it would actually fix the other issue in this repo #18. I'm a bit busy right now with personal life and moving so I won't have time to implement this but near the end of november things should clear up and I can try to implement the changes. I'd be open to renaming this repo to base16-nvim to match the style guide from base 16.

@EtiamNullam
Copy link
Contributor

@RRethy: I believe GitHub will still redirect from old link so changing repository name should be painless. At least that was the case for one of plugins I was using that also changed name.

More info: https://docs.github.com/en/repositories/creating-and-managing-repositories/renaming-a-repository

@RRethy
Copy link
Owner

RRethy commented Apr 23, 2022

Yup, renaming isn't a issue, the main issue is the 16 terminal colour support to make it eligible for that scheme list. This isn't super high on my priority list because most people (including myself) just use true colours.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants