bot.dig doesn't fail even if physically impossible

[tabbry]

• The FAQ doesn't contain a resolution to my issue

Versions

• mineflayer: 4.22.0
• server: vanilla 1.20.6
• node: 20.13.1

Detailed description of a problem

Invoking dig on the bot for a block, even when not physically possible, triggers the mining animation. However the "mining-texture" is not visible (expected), the block doesn't break (expected) and the digging command completes as if it was successful (unexpected).

Cases where this happens:

• Block is within spawn protected area, defined by server properties. Example: spawn-protection=16
• Bot is in game mode which doesn't allow it to break blocks: (spectator and usually adventure)

What did you try yet?

Using the examples/digger.js to isolate the problem and invoke dig for a block within and outside the spawn protected area.

Your current code

bot.dig(block).then(() => {
    // Invoked, even if not really successful.
    this.bot.chat(`Successfully digged block`)
}).catch(err => {
    // Not invoked, despite the fact that it was not successful.
    this.bot.chat(`Digging aborted block`)
})

Expected behavior

When digging fails (no matter the circumstances), it should throw an exception and thus follow the catch path and it should trigger the diggingAborted event.

Additional context

• Also applies to analogous use of try catch blocks.
• Also applies to analogous use of bot.canDigBlock(block)
• For spawn protection: Does not apply when the bot is in the op list, as this effectively ignores the spawn protection. (/op BOT to add the bot to op list, /deop BOT to remove.)

[u9g]

We don't really have a way to know whether digs will fail unless we try and it just comes back after a few ticks to my knowledge.

[Pix3lPirat3]

I am curious if listening for "Acknowledge Block Change" packet would work, however I'm not fully grasping what it is, maybe someone else could correct me if it wouldn't work