Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Components] Share components between monday.com apps #14603

Open
malexanderlim opened this issue Nov 7, 2024 · 3 comments · May be fixed by #14619
Open

[Components] Share components between monday.com apps #14603

malexanderlim opened this issue Nov 7, 2024 · 3 comments · May be fixed by #14619
Assignees
Labels
app New app / integration request enhancement New feature or request triaged For maintainers: This issue has been triaged by a Pipedream employee

Comments

@malexanderlim
Copy link
Collaborator

malexanderlim commented Nov 7, 2024

We created a new OAuth app for monday.com - this request is to port the existing components for the API key implementation over from monday (api key) to the new monday_oauth (oauth) app.

In order to test this, please ping @malexanderlim and I will share a link to install the app.

@malexanderlim malexanderlim added enhancement New feature or request app New app / integration request labels Nov 7, 2024
@malexanderlim malexanderlim removed the app New app / integration request label Nov 7, 2024
@sergio-eliot-rodriguez sergio-eliot-rodriguez added app New app / integration request triaged For maintainers: This issue has been triaged by a Pipedream employee labels Nov 7, 2024
@malexanderlim malexanderlim changed the title [APP] Share components between monday.com apps [Components] Share components between monday.com apps Nov 7, 2024
@michelle0927 michelle0927 self-assigned this Nov 8, 2024
@michelle0927 michelle0927 moved this from Prioritized to Doing in Component (Source and Action) Backlog Nov 8, 2024
@michelle0927 michelle0927 linked a pull request Nov 8, 2024 that will close this issue
@michelle0927 michelle0927 moved this from Doing to Ready for PR Review in Component (Source and Action) Backlog Nov 8, 2024
@luancazarine luancazarine moved this from Ready for PR Review to In Review in Component (Source and Action) Backlog Nov 11, 2024
@luancazarine luancazarine moved this from In Review to Ready for QA in Component (Source and Action) Backlog Nov 11, 2024
@vunguyenhung
Copy link
Collaborator

Hi @malexanderlim, I tried to setup my own Monday.com OAuth app and faced an error on Pipedream OAuth popup, as follow:
I created the Monday.com OAuth app to have Client ID, Client Secret, Signing Secret, and App ID
FireShot Capture 061 - monday - Apps - leo-pipedream monday com

Then I put the Pipedream OAuth Redirect URL
FireShot Capture 060 - monday - Apps - leo-pipedream monday com

On Pipedream Connection Popup, I filled all required fields
FireShot Capture 058 - OAuth Apps - Pipedream - pipedream com

Clicking connect, I see the OAuth popup shows my app correctly
Screenshot 2024-11-12 at 09 35 39

But after I click Authorize, the Pipedream OAuth popup shows error
Screenshot 2024-11-12 at 09 35 46

@vunguyenhung vunguyenhung moved this from Ready for QA to Blocked in Component (Source and Action) Backlog Nov 12, 2024
@malexanderlim
Copy link
Collaborator Author

Hey @vunguyenhung - please ping me and we can pair on this - I'm not able to reproduce this specific error when using my own custom oauth client, and would like to dig in on the exact flow that is breaking here.

@vunguyenhung vunguyenhung moved this from In QA to Ready for QA in Component (Source and Action) Backlog Nov 20, 2024
@vunguyenhung vunguyenhung moved this from Ready for QA to Changes Required in Component (Source and Action) Backlog Nov 20, 2024
@vunguyenhung
Copy link
Collaborator

Hello everyone, I have tested this PR and there're some test cases failed or needed improvement.

Please check the test report below for more information
https://vunguyenhung.notion.site/Components-Share-components-between-monday-com-apps-13bbf548bb5e81ee9225e80771dc6271

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app New app / integration request enhancement New feature or request triaged For maintainers: This issue has been triaged by a Pipedream employee
Projects
Development

Successfully merging a pull request may close this issue.

4 participants