Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better handling of exceptions during node evaluation. #153

Open
neuneck opened this issue Apr 16, 2021 · 3 comments
Open

Better handling of exceptions during node evaluation. #153

neuneck opened this issue Apr 16, 2021 · 3 comments

Comments

@neuneck
Copy link
Collaborator

neuneck commented Apr 16, 2021

Is your feature request related to a problem? Please describe.
When a node's compute method raises an exception, there's no neat way of handling that within flowpipe.

Describe the solution you'd like
I would like to be able to add an exception handler to nodes that gets executed when the node's compute raises an exception. Additionally, I would like to extend the Event interface, so that some events can provide additional information to their listeners, in this case the exception object.

Describe alternatives you've considered
As of now, all compute methods we use have a lot of exception handling, since any uncaught exception will interrupt the entire flow's execution. While this works, it's not elegant.

@DaveMtl
Copy link

DaveMtl commented Oct 21, 2021

Hi there,

I'm also looking for the best way to handle exceptions generated inside the compute function. As there been any developement on this?

As of now, all compute methods we use have a lot of exception handling, since any uncaught exception will interrupt the entire flow's execution. While this works, it's not elegant.

Once an exception is raised, how to you handle the flow of the graph? Do you interrupt it? Do you only interrupt downstream nodes ?

In our use case, interrupting the whole graph would be appropriate. Any advice on how to properly implement that?

@neuneck
Copy link
Collaborator Author

neuneck commented Oct 21, 2021 via email

@DaveMtl
Copy link

DaveMtl commented Oct 21, 2021

Makes sense, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants