Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sound tag IDs are spelled incorrectly, please fix asap. #11828

Closed
alexfry756 opened this issue Dec 26, 2024 · 6 comments · Fixed by #11829
Closed

Sound tag IDs are spelled incorrectly, please fix asap. #11828

alexfry756 opened this issue Dec 26, 2024 · 6 comments · Fixed by #11829

Comments

@alexfry756
Copy link

Expected behavior

in the /sound command there is an error with the sound. instead of the normal id of the sound tags it says "/sound craftsound{holder=reference{resourcekey[minecraft:sound_event / minecraft:ambient.basalt_deltas.additions]=soundevent[location=minecraft:ambient.basalt_deltas.additions, fixedrange=optional.empty]}}"

Up to version 15 of the kernel 1.21.4 paper such an error did not occur.

Observed/Actual behavior

It should be like this: sound ambient_basalt_deltas_additions

and so on with all the sound tags.

Steps/models to reproduce

Plugin and Datapack List

AuthMe, Citizens, CMI, CMILib, DeluxeMenus, Interactions, PL-Hide, PlaceholderAPI, WorldEdit, WorldGuard

Paper version

This server is running Paper version 1.21.4-41-main@d85d318 (2024-12-26T08:45:00Z) (Implementing API version 1.21.4-R0.1-SNAPSHOT)
You are running the latest version
Previous version: 1.21.4-15-bb76819 (MC: 1.21.4)

Other

No response

@Doc94
Copy link
Contributor

Doc94 commented Dec 26, 2024

Looks like an issue with CMI and how they are adding sounds to the command suggestions.

@electronicboy
Copy link
Member

electronicboy commented Dec 26, 2024

Sound is not a vanilla/paper command, this is likely an artifact of spigots recent changes exposing a flaw in how whatever plugin is providing that command is exposing this stuff;
er, wait, no, I lied, sound is a vanilla command, but, it's not using spigot stuff

@electronicboy electronicboy closed this as not planned Won't fix, can't repro, duplicate, stale Dec 26, 2024
@alexfry756
Copy link
Author

The thing is that the plugin was updated before the changes to version 15 of the server core, and when I just reverted back to version 15 of the core, everything started working fine.

@electronicboy
Copy link
Member

electronicboy commented Dec 26, 2024

46c6f49

is what what of induced this, the plugin is relying on broken implementation details, we can maybe fix mitigate this, I'd need to defer this to @Machine-Maker but, the plugin dev should really be the one to fix this

@electronicboy electronicboy reopened this Dec 26, 2024
@kennytv
Copy link
Member

kennytv commented Dec 26, 2024

Spigot has been warning about removing any assumptions of these enums being enums, that includes toString, so CMI needs to fix this in any case. Please also report it there

@alexfry756
Copy link
Author

I wrote to the CMI plugin developer on github.. I hope to get rid of this problem as soon as possible❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants