Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recursive refresh bug (severe) - with FIX #211

Open
brandyn opened this issue Jun 17, 2023 · 0 comments
Open

Recursive refresh bug (severe) - with FIX #211

brandyn opened this issue Jun 17, 2023 · 0 comments

Comments

@brandyn
Copy link

brandyn commented Jun 17, 2023

https://github.com/OpenZWave/python-openzwave/blob/8be4c070294348f3fc268bc1d7ad2c535f352f5a/src-api/openzwave/network.py#LL1524C35-L1524C35

This line is a severe bug, at least in my current build: In response to a node responding to a refresh request, this line sends the node another refresh request! (As far as I can tell, the line should just be removed. Not sure why it's there.)

It was flooding my logs with refreshes, so fast the rest of the network never could fully initialize. Basically borked my network. Commenting the line out fixed it. (Could instead have disabled it in node.py, but I assume it is correct there and the bug is in network.py)

I'm not sure why everyone doesn't run into this -- maybe using an older openzwave library that has broken refresh requesting or something?

(I don't grok git well enough to submit a patch but it's just one line that needs to go...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant