You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We are using requestPermission(fallbackToSettings) to request notification permissions from the user. According to this page, a "notifications are disabled" message should only be displayed if the value of the parameter is set to true.
fallbackToSettings- option to display a prompt informing your users to re-enable notifications for the app after they've denied permissions when showing a push prompt is disallowed.
However, when setting to false, a prompt is still displayed if notifications are disabled
I found a similar issue here in the React Native repo and this was due to the value of fallbackToSettings not being correctly cast as a boolean (see PR with fix here). However, as far as I can see, this is already being done in the Cordova SDK.
Steps to reproduce?
1. Install version 5.2.6 of `onesignal-cordova-plugin`2. Initialize OneSignal with `OneSignal.Notifications.requestPermission(false)`3. Build the app, sync over to a device
4. Disable notifications in IOS settings
5. Close and reload the app
What did you expect to happen?
The app should not display a message saying that notifications are disabled.
OneSignal Cordova SDK version
5.2.6
Which platform(s) are affected?
iOS
Android
Relevant log output
No response
Code of Conduct
I agree to follow this project's Code of Conduct
The text was updated successfully, but these errors were encountered:
What happened?
We are using
requestPermission(fallbackToSettings)
to request notification permissions from the user. According to this page, a "notifications are disabled" message should only be displayed if the value of the parameter is set to true.However, when setting to false, a prompt is still displayed if notifications are disabled
I found a similar issue here in the React Native repo and this was due to the value of fallbackToSettings not being correctly cast as a boolean (see PR with fix here). However, as far as I can see, this is already being done in the Cordova SDK.
Steps to reproduce?
What did you expect to happen?
The app should not display a message saying that notifications are disabled.
OneSignal Cordova SDK version
5.2.6
Which platform(s) are affected?
Relevant log output
No response
Code of Conduct
The text was updated successfully, but these errors were encountered: