Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark Mode Issue (stop/:id) Page #147

Open
Ahmedhossamdev opened this issue Nov 25, 2024 · 7 comments
Open

Dark Mode Issue (stop/:id) Page #147

Ahmedhossamdev opened this issue Nov 25, 2024 · 7 comments
Assignees

Comments

@Ahmedhossamdev
Copy link
Member

image

@Ritesh051
Copy link

@Ahmedhossamdev whats the main issue there ?

@Ahmedhossamdev
Copy link
Member Author

@Ritesh051

When dark mode is enabled, we expect to see the dark mode enabled in the entire app and pages, with a black color.

@Ritesh051
Copy link

Ohh it's pretty easy, assign me to this issue.

@Ahmedhossamdev
Copy link
Member Author

Ahmedhossamdev commented Dec 26, 2024

Done

see also

#146
#145

@Ritesh051
Copy link

ok Got it .

Ritesh051 added a commit to Ritesh051/wayfinder that referenced this issue Dec 26, 2024
@Ritesh051
Copy link

The issue has been fixed. I have raised a Pr.

@Ahmedhossamdev
Copy link
Member Author

Ahmedhossamdev commented Dec 26, 2024

Hi @Ritesh051,

Thanks for your effort on this PR! Good work, but after reviewing it, it seems the problem has not been fully fixed.
Additionally, we use Svelte 5 syntax, so instead of on:click, we use onclick.

See: https://svelte.dev/docs/svelte/v5-migration-guide

Our dark mode works well, so there's no need to edit the theme switcher. Instead, you should update the colors and add the dark class using Tailwind CSS on the required pages.

Feel free to reach out if you have any questions! 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants