Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source Sans Por font package renamed font breaking all referenes to it #157972

Closed
arximboldi opened this issue Feb 3, 2022 · 6 comments · Fixed by #163619
Closed

Source Sans Por font package renamed font breaking all referenes to it #157972

arximboldi opened this issue Feb 3, 2022 · 6 comments · Fixed by #163619

Comments

@arximboldi
Copy link
Contributor

arximboldi commented Feb 3, 2022

Describe the bug

The Source Sans Pro font as installed by the source-sans-pro package, is now called Source Sans 3. This breaks all references to the font in documents, but also in web pages, etc. The font

Steps To Reproduce

Open this webpage: https://github.com/arximboldi/immer
The logo uses the Source Sans Pro font and it should look correct when the source-sans-pro package is installed. Instead, it shows an alternative font with serif.

Expected behavior

The font should be called Source Sans Pro and not Source Sans Pro 3, keeping all references. If this was not desirable (because the font is just too different) then a package should be provided to install the old version with the old name.

Notify maintainers

@ttuegel

Metadata

Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.

[user@system:~]$ nix-shell -p nix-info --run "nix-info -m"
 - system: `"x86_64-linux"`
 - host os: `Linux 5.10.93, NixOS, 21.11 (Porcupine)`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.3.16`
 - channels(root): `"nixos-21.11.335665.0f316e4d72d, nixos-18.03-18.03.133402.cb0e20d6db9, nixos-18.09-18.09.2574.a7e559a5504, nixos-19.03-19.03.173691.34c7eb7545d, nixos-19.09-19.09.2522.75f4ba05c63, nixos-20.03-20.03.3330.1db42b7fe38, nixos-20.09-20.09.4407.1c1f5649bb9, nixos-unstable-22.05pre350017.efeefb2af14"`
 - channels(raskolnikov): `"nixgl, nixpkgs-22.05pre335173.56cbe42f166"`
 - nixpkgs: `/home/raskolnikov/.nix-defexpr/channels/nixpkgs`
@andersk
Copy link
Contributor

andersk commented Feb 4, 2022

The upstream name change was intentional (adobe-fonts/source-serif#77).

@arximboldi
Copy link
Contributor Author

arximboldi commented Feb 5, 2022

Thank you andersk that explains a lot! I guess then it makes sense to also install the older version?
Edit: or provide it as a separate package.

@ttuegel
Copy link
Member

ttuegel commented Feb 11, 2022

We should be able to deal with this through fontconfig.

@wentasah
Copy link
Contributor

wentasah commented Mar 7, 2022

If I understand correctly, it's not only the name that has been changed, but the renamed font has also different metrics. This means that if we just configure fontconfig to replace "Source Sans Pro" with "Source Sans 3", the layout of existing documents might change.

So I think, it would make sense to either reintroduce Pro fonts as a separate package, or include the older (Pro) version together with the new one (which is what Archlinux is doing).

If @ttuegel is interested, I can turn my commit, which does the former, to a PR.

@arximboldi
Copy link
Contributor Author

So I think, it would make sense to either reintroduce Pro fonts as a separate package, or include the older (Pro) version together with the new one (which is what Archlinux is doing).

I agree. Either of these two solutions would be satisfying to me.

@ttuegel
Copy link
Member

ttuegel commented Mar 9, 2022

So I think, it would make sense to either reintroduce Pro fonts as a separate package, or include the older (Pro) version together with the new one (which is what Archlinux is doing).

If @ttuegel is interested, I can turn my commit, which does the former, to a PR.

@wentasah I wasn't aware of the metrics changes. I think adding the older version back as a new package makes perfect sense, thank you!

wentasah added a commit to wentasah/nixpkgs that referenced this issue Mar 10, 2022
Recently, Source Sans/Serif Pro fonts got renamed. The "Pro" suffix
was replaced with the major version of the font name.

In the case of Source Serif, the change was announced in
adobe-fonts/source-serif#77 and besides the
name font metric have been changed too. Therefore, documents using the
old "Pro" version might look differently when the font is changed to
the new "4" version.

In the case of Source Sans, the metrics seem not to have been
changed (adobe-fonts/source-sans#192), but
this comment (adobe-fonts/source-sans#192 (comment))
suggests that it might happen in the future.

Due to the above, it makes sense to keep both old "Pro" and
new (numbered) fonts as separate packages. This commit reintroduced
the old "Pro" versions.

It seems that Arch Linux is also distributing both versions:
https://github.com/archlinux/svntogit-packages/blob/0d70461e5a26cde02cadfda64078eb93192c6caa/trunk/PKGBUILD

Closes NixOS#157972
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants