Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] id should be compulsory in Instance #196

Open
sanjayankur31 opened this issue Sep 1, 2022 · 0 comments
Open

[Bug] id should be compulsory in Instance #196

sanjayankur31 opened this issue Sep 1, 2022 · 0 comments
Labels
C: NeuroML2 standard Component: NeuroML 2 standard T: bug Type: bug

Comments

@sanjayankur31
Copy link
Member

id in Instance should be required, but is currently not because we can either provide an id or i, j, k locations. This condition is not currently included in the schema, so if someone misses the id, but does not give i, j, k values, the model is still valid---but will throw cryptic errors when LEMS tries to parse/simulate it.

We intend to drop regions etc. soon, and that'll also allow us to drop the i, j, k attributes here and make id a required attribute.

@sanjayankur31 sanjayankur31 added T: bug Type: bug C: NeuroML2 standard Component: NeuroML 2 standard labels Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: NeuroML2 standard Component: NeuroML 2 standard T: bug Type: bug
Projects
Status: 🔖 Ready
Development

No branches or pull requests

1 participant