Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi Segment integration #116

Open
samuelgarcia opened this issue Oct 23, 2020 · 1 comment
Open

Multi Segment integration #116

samuelgarcia opened this issue Oct 23, 2020 · 1 comment

Comments

@samuelgarcia
Copy link
Collaborator

Here a thread to discuss how to integrate multi segment in ephyviewer.

Some user have have multi segment dataset.
The way it is built is that one window = one segment.
Some times it is not very convinient to open and close for each segment.

If we want all segment in one window, we can have several apporach:

  1. make source "aggregator", if t_start are correctly distributed along time without overlap between segment
    we could have a source that would aggrgate several other sources.
  2. we could have explicit segment swap in he main window (like a combo box that would switch all viewer to the next segment).

Both approach represent some work. This is why I open the discussion.

Jeffrey : what do you think ?

@jpgill86

@jpgill86
Copy link
Collaborator

I agree that adding multi-segment would be great!

I want to make sure I understand Approach 1. Is your suggestion that the "aggregator" could concatenate sources if t_start(n) > t_stop(n-1) for all n segments?

For example, if segment 2's t_start is later than segment 1's t_stop, and if their AnalogSignals are completely "congruent" (e.g., same numbers of AnalogSignals with same names and same number of channels each), then segment 2's AnalogSignals could be appended to segment 1's.

Is it the case that Neo guarantees that Segments within a Block are all congruent? If not, ephyviewer could need to check.

Approach 2 seems like the lower hanging fruit, and it should be able to handle the general case where the t_starts are not correctly distributed, or when sources are not congruent across segments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants