We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The PDF for the GGX VNDF is wrong here:
donut/include/donut/shaders/brdf.hlsli
Lines 232 to 241 in b52bc31
The correct version has to include the G1 term and the VoH of the determinant cancels:
// ... float D = square(alpha) / (M_PI * square(square(NoH) * square(alpha) + (1 - square(NoH)))); float G1 = //... return (D * G1) / (4 * VoN);
The text was updated successfully, but these errors were encountered:
No branches or pull requests
The PDF for the GGX VNDF is wrong here:
donut/include/donut/shaders/brdf.hlsli
Lines 232 to 241 in b52bc31
The correct version has to include the G1 term and the VoH of the determinant cancels:
The text was updated successfully, but these errors were encountered: