Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clean up get_grid_version routines for data_override #1371

Open
rem1776 opened this issue Sep 19, 2023 · 0 comments · May be fixed by #1514
Open

clean up get_grid_version routines for data_override #1371

rem1776 opened this issue Sep 19, 2023 · 0 comments · May be fixed by #1514
Assignees
@J-Lentz
Labels
enhancement Issue/PR for a modification that increases performance, improves syntax, or adds functionality.

Comments

@rem1776
Copy link
Contributor

rem1776 commented Sep 19, 2023 •
edited
Loading

Is your feature request related to a problem? Please describe.
get_grid_version_1 and 2 have an argument for compute domain indices, but then queries the domain for global and compute indices. (only uses global domain indices though)

Describe the solution you'd like
The arguments should be cleaned up to only provide whats needed

Describe alternatives you've considered
indices argument can probably be removed

Additional context
came up with mixed precision
@rem1776 rem1776 added the enhancement Issue/PR for a modification that increases performance, improves syntax, or adds functionality. label Sep 19, 2023
@rem1776 rem1776 mentioned this issue Sep 19, 2023
Merged
8 tasks
@J-Lentz J-Lentz self-assigned this Sep 20, 2023
@J-Lentz J-Lentz linked a pull request May 8, 2024 that will close this issue
Open
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@J-Lentz J-Lentz

Labels
enhancement Issue/PR for a modification that increases performance, improves syntax, or adds functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Simplify argument lists of subroutines in get_grid_version_mod J-Lentz/FMS
2 participants
@rem1776 @J-Lentz