Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

need to consolidate code for vertical scaling of SLA and vcmax #1167

Open
rgknox opened this issue Mar 5, 2024 · 0 comments
Open

need to consolidate code for vertical scaling of SLA and vcmax #1167

rgknox opened this issue Mar 5, 2024 · 0 comments
Labels
refactor Restructures code without changing functionality

Comments

@rgknox
Copy link
Contributor

rgknox commented Mar 5, 2024

We have methods that scale SLA over depth:

https://github.com/NGEET/fates/blob/sci.1.72.0_api.33.0.0/biogeochem/FatesAllometryMod.F90#L696

We also have methods that scale vcmax used in photosynthesis, that should match this profile (or at least that is what the intention was). So these two profiles should be synchronized.

https://github.com/NGEET/fates/blob/sci.1.72.0_api.33.0.0/biogeophys/FatesPlantRespPhotosynthMod.F90#L546-L549
https://github.com/NGEET/fates/blob/sci.1.72.0_api.33.0.0/biogeophys/FatesPlantRespPhotosynthMod.F90#L2490

I believe the underlying assumption of these two scaling methods is that leaf nitrogen concentration is constant with leaf area (thus, leaf nitrogen concentration varies over depth).

However, for the former method, if the user sets the min sla to equal the max sla, then they will get no sla scaling over depth.
But the vcmax scaling algorithm is unaffected. This may not be what was originally intended?

I think these algorithms needs a refactor so that that each of them are using shared code for vertical scaling.

@glemieux glemieux added the refactor Restructures code without changing functionality label Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Restructures code without changing functionality
Projects
Status: ❕Todo
Development

No branches or pull requests

2 participants