Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C3/C4 assignment is incorrect in Ryan 1991 leaf maintenance respiration code #1052

Closed
JessicaNeedham opened this issue Jul 17, 2023 · 0 comments · Fixed by #1053
Closed

C3/C4 assignment is incorrect in Ryan 1991 leaf maintenance respiration code #1052

JessicaNeedham opened this issue Jul 17, 2023 · 0 comments · Fixed by #1053

Comments

@JessicaNeedham
Copy link
Contributor

EDPftvarcon_inst%c3psn(ft) is 0 for C4 and 1 for C3 plants:

fates_leaf_c3psn:long_name = "Photosynthetic pathway (1=c3, 0=c4)" ;

But in the Ryan 1991 leaf MR code the wrong check is used meaning that the C4 temperature sensitivity adjustment is being used for C3 plants (and vice versa):

if (nint(EDPftvarcon_inst%c3psn(ft)) /= 1) then

This code should instead use the c3c4_path_index used in other places in the code (e.g.):

c3c4_path_index = nint(EDPftvarcon_inst%c3psn(ft))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant