Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bug: fug: mom6 perturbation model specific perturbation #730

Open
hkershaw-brown opened this issue Sep 5, 2024 · 3 comments
Open
Assignees
Labels
mom6 Modular Ocean Model

Comments

@hkershaw-brown
Copy link
Member

hkershaw-brown commented Sep 5, 2024

Perturbing MOM6 to get some ensembles to play with.
Currently (lazily) using the default perturbation routine, which perturbs everything in the state including land.

This gives some fuzz on the land:

c.TL319_t232.001
Screenshot 2024-09-05 at 4 25 36 PM

nwa12_test.3_0_a03a
Screenshot 2024-09-05 at 4 28 47 PM

Compare to non-fuzz before perturbation
Screenshot 2024-09-05 at 4 33 00 PM

who cares?
You'll inflate the land because mean /= 0 (adds more fuzz), get_close makes 'dry' state far away so the assimilation update doesn't change the land, but still I think dangerous to fuzz.
See #359 for missing_in_state comment that I have not rewritten yet. #359 (comment)

@hkershaw-brown
Copy link
Member Author

hkershaw-brown commented Sep 6, 2024

note: land is land+ocean floor

todo @HKershaw get_state_meta_data / get_close_state should be checking ocean floor?

This ocean floor check wrong/not needed?

lon_lat_vert = get_location(locs(close_ind(ii))) ! assuming VERTISHEIGHT
call get_model_variable_indices(loc_indx(ii), i, j, k)
if ( below_sea_floor(i,j,lon_lat_vert(3)) ) dist = 1.0e9_r8

@hkershaw-brown
Copy link
Member Author

I'm not sure what the MOM6 grid looks like:
Screenshot 2024-09-06 at 9 52 35 AM

2D wet/dry sufficient (squishy bottom grid follows ocean basin) vs. 3D wet/dry (grid extends into ocean basin)

@hkershaw-brown hkershaw-brown added the mom6 Modular Ocean Model label Sep 11, 2024
@hkershaw-brown hkershaw-brown self-assigned this Sep 11, 2024
hkershaw-brown added a commit that referenced this issue Sep 11, 2024
@hkershaw-brown
Copy link
Member Author

https://github.com/NCAR/DART/tree/pert_plus_missing-grid has pert_model_copies & missing grid from #727 so it can run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mom6 Modular Ocean Model
Projects
None yet
Development

No branches or pull requests

1 participant