Skip to content

Latest commit

 

History

History
11 lines (9 loc) · 1.25 KB

code-of-conduct.md

File metadata and controls

11 lines (9 loc) · 1.25 KB

KubeClipper Code of Conduct

Best Practices of Committing Code

  • As gopher, make sure you already read the conduct of Go language and the instruction of writing Go.
  • Fork the project under your GitHub account and make the changes you want there.
  • Execute 'make checkfmt' for every piece of new code.
  • Every pulling request (PR) would be better constructed with only one commit, which could help code reviewer to go through your code efficiently, also helpful for every follower of this project to understand what happens in this PR. If you need to make any further code change to address the comments from reviewers, which means some new commits will be generated under this PR, you need to use 'git rebase' to combine those commits together.
  • Every PR should only solve one problem or provide one feature. Don't put several different fixes into one PR.
  • At lease two code reviewers should involve into code reviewing process.
  • Please introduce new third-party packages as little as possible to reduce the vendor dependency of this project. For example, don't import a full unit converting package but only use one function from it. For this case, you'd better write that function by yourself.