Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use @metamask/superstruct, set moduleResolution to NodeNext #186

Closed
MajorLift opened this issue May 29, 2024 · 0 comments · Fixed by #185, #194 or #196
Closed

Use @metamask/superstruct, set moduleResolution to NodeNext #186

MajorLift opened this issue May 29, 2024 · 0 comments · Fixed by #185, #194 or #196
Assignees
@MajorLift
Labels
team-wallet-framework

Comments

@MajorLift
Copy link
Contributor

Explanation

As part of our OKR for upgrading TypeScript to v5.0+ (Q2 2024 O3KR4), we are updating our core dependencies to generate builds and type declarations for both CJS and ESM.

Tasks

  • Replace all references to superstruct with ESM-compatible @metamask/superstruct fork.
  • Set TypeScript module, moduleResolution options to NodeNext.

References
@MajorLift MajorLift self-assigned this May 29, 2024
@MajorLift MajorLift added bug Something isn't working team-wallet-framework labels May 29, 2024
@MajorLift MajorLift mentioned this issue May 29, 2024
Merged
@MajorLift MajorLift removed the bug Something isn't working label May 29, 2024
@MajorLift MajorLift mentioned this issue May 30, 2024
Closed
MajorLift added a commit that referenced this issue Jun 4, 2024
@MajorLift @mcmire
Use @metamask/superstruct, set moduleResolution to NodeNext (#185)
631d1eb 
## Explanation

As part of our OKR for upgrading TypeScript to v5.0+ (Q2 2024 O3KR4), we
are updating our core dependencies to generate builds and type
declarations for both CJS and ESM.

- Replaces all references to `superstruct` with ESM-compatible
`@metamask/superstruct` fork.
- Set TypeScript `module`, `moduleResolution` options to `NodeNext`.

## References

- Closes: #186
- Blocks: MetaMask/core#3651
- Blocked by: MetaMask/superstruct#20

## Changelog

```md
### Changed

- **BREAKING:** Replace dependency `superstruct` `^1.0.3` with ESM-compatible `@metamask/superstruct` `^3.0.0` ([#185](#185)).
- Bump devDependency `typescript` from `~4.8.4` to `~5.0.4` ([#185](#185)).
```

---------

Co-authored-by: Elliot Winkler <[email protected]>
@MajorLift MajorLift reopened this Jun 4, 2024
@MajorLift MajorLift reopened this Jun 27, 2024
@MajorLift MajorLift mentioned this issue Jun 27, 2024
Merged
@MajorLift MajorLift reopened this Jun 27, 2024
This was linked to pull requests Jun 27, 2024
8.5.1 #195
Closed
9.0.0 #196
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MajorLift MajorLift

Labels
team-wallet-framework
Projects
None yet
Milestone
No milestone
1 participant
@MajorLift