Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge Extension AccountsTrackerController with the core one #1809

Open
mcmire opened this issue Oct 11, 2023 · 1 comment
Open

Merge Extension AccountsTrackerController with the core one #1809

mcmire opened this issue Oct 11, 2023 · 1 comment
Assignees

Comments

@mcmire
Copy link
Contributor

mcmire commented Oct 11, 2023

These controllers are similar but have separate implementations. We will need to dive into how they are used in the extension vs. mobile app to understand what a combined version should look like.

While we are doing this, we may need to:

  • Extract any API interactions or complex utility functions
  • Refactor to be more easily understood
  • Write comprehensive unit tests

Additionally, there are patches in mobile around AccountTrackerController under @metamask/assets-controllers, and we will want to make sure those are integrated as well.

@mcmire mcmire added the Epic label Oct 11, 2023
@desi desi removed the Epic label Oct 3, 2024
@desi desi changed the title Merge AccountTrackerController with CachedBalancesController (from extension), and migrate to this repo Merge Extension AccountsTrackerController with the core one Oct 3, 2024
@desi
Copy link
Contributor

desi commented Oct 3, 2024

Notes: Extension has support for single call balances contract to do a balance update with a single call and we need that feature on the one on core.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants