relay::io::blueprint::load_mesh() recognizes yaml as json

[JustinPrivitera]

This is the blueprint index.

blueprint_index: 
  mesh: 
    state: 
      cycle: 48
      time: 4.8
      path: "mesh/state"
      number_of_domains: 36
      partition_pattern: "visit_ex_db.cycle_000048/domain_{domain:06d}.yaml:/"
      partition_map: 
        file: [0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24, 25, 26, 27, 28, 29, 30, 31, 32, 33, 34, 35]
        domain: [0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24, 25, 26, 27, 28, 29, 30, 31, 32, 33, 34, 35]
    coordsets: 
      coords: 
        type: "explicit"
        coord_system: 
          axes: 
            x: 
            y: 
            z: 
          type: "cartesian"
        path: "mesh/coordsets/coords"
    topologies: 
      topo: 
        type: "structured"
        coordset: "coords"
        path: "mesh/topologies/topo"
    fields: 
      d: 
        number_of_components: 1
        topology: "topo"
        association: "element"
        path: "mesh/fields/d"
protocol: 
  name: "yaml"
  version: "0.9.0"
number_of_files: 36
number_of_trees: 36
file_pattern: "visit_ex_db.cycle_000048/domain_%06d.yaml"
tree_pattern: "/"

This is the logic for determining the protocol:

            // for json or yaml, lets make sure a new line exists
            if(test_str.find("\n") != std::string::npos)
            {
                // for yaml look for ":" 
                // for json, look for "{"
                if(test_str.find(":") != std::string::npos)
                {
                   file_type = "yaml";
                }
                if(test_str.find("{") != std::string::npos)
                {
                   file_type = "json";
                }
            }

So because of this line:

partition_pattern: "visit_ex_db.cycle_000048/domain_{domain:06d}.yaml:/"

the protocol is erroneously assumed to be json.

I have attached the yaml files I used to reproduce this.

visit_ex_db.cycle_000048.tar.xz.zip

[cyrush]

conduit/src/libs/relay/conduit_relay_io_identify_protocol.cpp

Line 151 in ad86e31

if(test_str.find("\n") != std::string::npos)

[JustinPrivitera]

There's nothing wrong with checking for newline, right? It's the { that breaks it.

[cyrush]

yes, I just wanted to link the code in the issue + I linked near - not the exact spot.