Ensure Docker TPL builds use +devtools variant

[bmhan12]

I noticed as part of the clang@14 and gcc@13 Docker builds, Axom is building +devtool dependencies like doxygen and graphviz, but not building with the +devtool variant in the spec.

You can see in the output host-config artifacts that no devtools are enabled:
https://github.com/LLNL/axom/actions/runs/9881233214

[white238]

To my knowledge the docker containers should not be building the devtools spec:

axom/scripts/docker/dockerfile_clang-14

Line 36 in 1235eb8

--spec=%[email protected]+mfem+raja+umpire+profiling --prefix=/home/axom/axom_tpls -k \

also in the build log it is turned off:

https://github.com/LLNL/axom/actions/runs/9881233214/job/27291573128#step:8:5489

Where do you see it building those dependencies?

[bmhan12]

Where do you see it building those dependencies?

I saw that the docker builds were using apt-get to get devtools dependencies and explicitly downloading a doxygen tarball, so it made it seem the next step would be to build with +devtools:

axom/scripts/docker/dockerfile_clang-14

Lines 9 to 16 in 1235eb8

	RUN sudo apt-get install gettext gfortran-$(gcc -dumpversion) graphviz libomp-14-dev libopenblas-dev \
	lsb-release lua5.2 lua5.2-dev mpich python3-sphinx ssh texlive-full -fy
	RUN sudo useradd -m -s /bin/bash -G sudo axom
	# Install proper doxygen version (should match version in LC host configs)
	RUN sudo wget https://github.com/doxygen/doxygen/releases/download/Release_1_9_8/doxygen-1.9.8.linux.bin.tar.gz
	RUN sudo tar -xf doxygen-1.9.8.linux.bin.tar.gz
	RUN cd doxygen-1.9.8 && sudo make && sudo make install && doxygen --version

EDIT: And providing external packages in the Docker spack.yaml for devtool dependencies:

axom/scripts/spack/configs/docker/ubuntu22/spack.yaml

Lines 170 to 194 in 1235eb8

	# Globally lock in version of devtools
	cmake:
	version: [3.23.1]
	buildable: false
	externals:
	- spec: [email protected]
	prefix: /usr/local
	doxygen:
	version: [1.9.1]
	buildable: false
	externals:
	- spec: [email protected]
	prefix: /usr
	llvm:
	version: [14.0.0]
	buildable: false
	externals:
	- spec: [email protected]+clang
	prefix: /usr
	py-sphinx:
	version: [4.3.2]
	buildable: false
	externals:
	- spec: [email protected]
	prefix: /usr

[white238]

Ah yes. We could add them as Spack externals but Axom doesn't currently use any of the devtools in its CI. It certainly could, and should probably. We do utilize clangformat for a style check. Serac has doxygen check that we could add that ensures no warning/errors in the doxygen build but this would be a large effort to get it to an empty state. It was left off because we just aren't using them.