New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimise Twig extension #396

Open

garak opened this issue Sep 2, 2024 · 0 comments · May be fixed by #397

Labels

Collaborator

garak commented Sep 2, 2024

Our current Twig extension is not optimised. See https://symfony.com/doc/7.2/templates.html#creating-lazy-loaded-twig-extensions for a reference about the subject.

A pull request to solve this issue should:

create a new Runtime class, and move all the dependencies of the current Extension class
remove the dependencies from the Extension class, using the method from the Runtime instead
adapt the service configuration to fit the above

garak added the Improvement label

garak linked a pull request

that will close this issue

add Twig Runtime #397

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment