Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify fitlog logic #618

Open
palday opened this issue May 20, 2022 · 0 comments
Open

Simplify fitlog logic #618

palday opened this issue May 20, 2022 · 0 comments
Labels
breaking proposed breaking change

Comments

@palday
Copy link
Member

palday commented May 20, 2022

If we want to have fitlog contain the initial and final parameter and objective values and have the .initial, .final fields just point to those values we should expand the schema for fitlog to include the evaluation number (and increment it at the beginning of the obj function, not in the middle as is done now). Either that or abandon the idea of using thin and just incorporate a Boolean logevaluations or some name like that. I doubt very much that many users will choose values of thin other than the default, typemax(Int) or 1.

Originally posted by @dmbates in #615 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking proposed breaking change
Projects
None yet
Development

No branches or pull requests

1 participant