Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

port graytype from Images.jl to ImageCore.jl #96

Open
johnnychen94 opened this issue Nov 28, 2019 · 2 comments
Open

port graytype from Images.jl to ImageCore.jl #96

johnnychen94 opened this issue Nov 28, 2019 · 2 comments
Labels
good first issue Would make a good contribution from new contributors

Comments

@johnnychen94
Copy link
Member

johnnychen94 commented Nov 28, 2019 •
edited
Loading

https://github.com/JuliaImages/Images.jl/blob/373d1427232a08d9c6747222404d27e4d54faed8/src/algorithms.jl#L285-L287

I know that Gray(rand(RGB{N0f8})) converts an RGB pixel to Gray pixel while preserving the storage type. Can we support similar operations for Colorant such as Gray(RGB{N0f8}) == Gray{N0f8}?
@timholy timholy added the good first issue Would make a good contribution from new contributors label Jan 27, 2020
@Jay-sanjay
Copy link
Contributor

From the best I know -yes, we can support similar operations for the Colorant type using the Gray constructor

@Jay-sanjay
Copy link
Contributor

what are your views on it sir.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Would make a good contribution from new contributors
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@timholy @johnnychen94 @Jay-sanjay