Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to BenchmarkCI? #116

Open
timholy opened this issue Jan 27, 2020 · 3 comments
Open

Move to BenchmarkCI? #116

timholy opened this issue Jan 27, 2020 · 3 comments
Assignees
Labels
good first issue Would make a good contribution from new contributors

Comments

@timholy
Copy link
Member

timholy commented Jan 27, 2020

JuliaImages/ImageFiltering.jl#150 reorganized the benchmarks for ImageFiltering into a form that would run on each PR and report results separately from tests. To me this seems more useful than the strategy currently used here, where the benchmarks run but failures are reported as warnings. We could consider switching to BenchmarkCI.

@timholy timholy added the good first issue Would make a good contribution from new contributors label Jan 27, 2020
@johnnychen94 johnnychen94 self-assigned this Jan 27, 2020
@johnnychen94
Copy link
Member

johnnychen94 commented Jan 27, 2020

There're still some issues to be fixed before the wide usage of BenchmarkCI, e.g, PRs from other forks don't trigger that, CI script doesn't get auto-updates. I prefer to fix them upstream first, and then apply to JuliaImages.

@johnnychen94
Copy link
Member

The current benchmark script seems to only benchmark getindex and setindex for channelview and colorview. What's other things you have in mind that definitely worth a benchmark?

@timholy
Copy link
Member Author

timholy commented Mar 12, 2020

Those alone are quite good, and already highlight areas that need fixing (ReinterpretArray has been a bit of a problem child). Perhaps we can add the various functions in src/map.jl. That may be about it, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Would make a good contribution from new contributors
Projects
None yet
Development

No branches or pull requests

2 participants