Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

url_parse does not detect the domain accurately #90

Open
mkhezr opened this issue Aug 15, 2018 · 3 comments
Open

url_parse does not detect the domain accurately #90

mkhezr opened this issue Aug 15, 2018 · 3 comments

Comments

@mkhezr
Copy link

mkhezr commented Aug 15, 2018

I am using urltools::url_parse on a medium.com type of url:

urltools::url_parse("https://medium.com/@mkhezr/plastic-fashion-a-data-story-4c65ff6efc36")

and instead of medium.com being detected as the domain, the writer's username part @mkhezr is:

scheme domain port path parameter fragment
https mkhezr <NA> plastic-fashion-a-data-story-4c65ff6efc36 <NA> <NA>

I'm using urltools version 1.7.0

@alexcpsec
Copy link
Collaborator

👍 I was just looking at a similar thing right now.

@Ironholds is this something you think I could help with?

@Ironholds
Copy link
Owner

@alexcpsec if you want to try tinkering with the logic, go for it! (I have a conference deadline iiin 3 weeks and so am currently only writing in LaTeX :D

ekamioka added a commit to ekamioka/urltools that referenced this issue Aug 29, 2018
ghost pushed a commit to alexcpsec/urltools that referenced this issue Dec 4, 2018
alexcpsec added a commit to alexcpsec/urltools that referenced this issue Dec 6, 2018
@hrbrmstr
Copy link
Collaborator

hrbrmstr commented Dec 8, 2018

side note: while the following won't work on Windows until the hack-ish rwinlib setup updates the compiled libcurl for windows that it downloads on install (shudder), https://github.com/hrbrmstr/curlparse curlparse::parse_curl() parses this URL just fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants