-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
url_parse does not detect the domain accurately #90
Comments
👍 I was just looking at a similar thing right now. @Ironholds is this something you think I could help with? |
@alexcpsec if you want to try tinkering with the logic, go for it! (I have a conference deadline iiin 3 weeks and so am currently only writing in LaTeX :D |
fix to the issue Ironholds#90
side note: while the following won't work on Windows until the hack-ish rwinlib setup updates the compiled libcurl for windows that it downloads on install (shudder), https://github.com/hrbrmstr/curlparse |
I am using
urltools::url_parse
on a medium.com type of url:urltools::url_parse("https://medium.com/@mkhezr/plastic-fashion-a-data-story-4c65ff6efc36")
and instead of
medium.com
being detected as the domain, the writer's username part@mkhezr
is:scheme domain port path parameter fragment
https mkhezr <NA> plastic-fashion-a-data-story-4c65ff6efc36 <NA> <NA>
I'm using urltools version
1.7.0
The text was updated successfully, but these errors were encountered: