From 7256bfb51b701cd7ea12c599286ab58bd3aa5206 Mon Sep 17 00:00:00 2001 From: Kent Sutherland Date: Wed, 11 Oct 2023 21:26:38 -0700 Subject: [PATCH] Update iOS deployment target to silence Xcode 15 warnings (#1589) Summary: ## Changes in this pull request Xcode 15 has moved the iOS deployment target up to iOS 12 (just like https://github.com/Instagram/IGListKit/issues/1573 for Xcode 14). I did not modify the changelog because there's already an entry there for iOS 11 and macOS 10.13. This also includes a build error fix for IGWarnAssert (dffcd4d0c8d0a5b7ad80322e6cd74b7787da2a12). I tried running the unit tests but a number of them are failing from previous changes. ### Checklist - [ ] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [ ] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/main/.github/CONTRIBUTING.md) Pull Request resolved: https://github.com/Instagram/IGListKit/pull/1589 Reviewed By: fabiomassimo Differential Revision: D50013207 Pulled By: TimOliver fbshipit-source-id: 6c7a7b2ca3dd1265f11e85979432eded3292ed06 --- IGListKit.xcodeproj/project.pbxproj | 12 ++++++------ .../xcshareddata/xcschemes/IGListKit-macOS.xcscheme | 2 +- .../xcshareddata/xcschemes/IGListKit-tvOS.xcscheme | 2 +- .../xcshareddata/xcschemes/IGListKit.xcscheme | 2 +- 4 files changed, 9 insertions(+), 9 deletions(-) diff --git a/IGListKit.xcodeproj/project.pbxproj b/IGListKit.xcodeproj/project.pbxproj index 6ad729dc1..c1a8a5944 100644 --- a/IGListKit.xcodeproj/project.pbxproj +++ b/IGListKit.xcodeproj/project.pbxproj @@ -376,6 +376,7 @@ 88144F1D1D870EDC007C7F66 /* IGTestSupplementarySource.m in Sources */ = {isa = PBXBuildFile; fileRef = 88144F061D870EDC007C7F66 /* IGTestSupplementarySource.m */; }; 882BC1321E0118CB0083B311 /* IGTestObject.m in Sources */ = {isa = PBXBuildFile; fileRef = 88144F001D870EDC007C7F66 /* IGTestObject.m */; }; 883797082022304E00B94676 /* (null) in Headers */ = {isa = PBXBuildFile; }; + 883797082022304E00B94676 /* BuildFile in Headers */ = {isa = PBXBuildFile; }; 88379728202236AB00B94676 /* IGListAdapterUpdateTester.m in Sources */ = {isa = PBXBuildFile; fileRef = 294CDE621F995DD7002CF6E4 /* IGListAdapterUpdateTester.m */; }; 88379729202236AC00B94676 /* IGListAdapterUpdateTester.m in Sources */ = {isa = PBXBuildFile; fileRef = 294CDE621F995DD7002CF6E4 /* IGListAdapterUpdateTester.m */; }; 885FE1DD1DC51A0D009CE2B4 /* IGListKit.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = 885FE1D41DC51A0D009CE2B4 /* IGListKit.framework */; }; @@ -440,7 +441,6 @@ F1ED68B329E9B3B9003744F8 /* IGListInteractiveMovingTests.m in Sources */ = {isa = PBXBuildFile; fileRef = F1ED68AE29E9B3B9003744F8 /* IGListInteractiveMovingTests.m */; }; F1ED68B529E9B3B9003744F8 /* IGListDebugDescriptionTests.m in Sources */ = {isa = PBXBuildFile; fileRef = F1ED68AF29E9B3B9003744F8 /* IGListDebugDescriptionTests.m */; }; F1ED68B729E9B3B9003744F8 /* IGListTransactionTests.m in Sources */ = {isa = PBXBuildFile; fileRef = F1ED68B029E9B3B9003744F8 /* IGListTransactionTests.m */; }; - F1ED68B929E9B3B9003744F8 /* IGListSingleSectionControllerTests.m in Sources */ = {isa = PBXBuildFile; fileRef = F1ED68B129E9B3B9003744F8 /* IGListSingleSectionControllerTests.m */; }; F1ED68BA29E9B404003744F8 /* IGListInteractiveMovingTests.m in Sources */ = {isa = PBXBuildFile; fileRef = F1ED68AE29E9B3B9003744F8 /* IGListInteractiveMovingTests.m */; }; F1ED68BB29E9B40A003744F8 /* IGListGenericSectionControllerTests.m in Sources */ = {isa = PBXBuildFile; fileRef = 29DA5CA21EA7C72400113926 /* IGListGenericSectionControllerTests.m */; }; F1ED68BC29E9B411003744F8 /* IGListDebuggerTests.m in Sources */ = {isa = PBXBuildFile; fileRef = 290DF3761E9323E6009FE456 /* IGListDebuggerTests.m */; }; @@ -1441,6 +1441,7 @@ buildActionMask = 2147483647; files = ( 883797082022304E00B94676 /* (null) in Headers */, + 883797082022304E00B94676 /* BuildFile in Headers */, 7A02D0C023615CE500B49FAE /* IGListKit.h in Headers */, ); runOnlyForDeploymentPostprocessing = 0; @@ -1968,7 +1969,6 @@ 298DD9CF1E3ADD1400F76F50 /* IGListBindingSectionControllerTests.m in Sources */, 885FE22F1DC51B76009CE2B4 /* IGListDiffSwiftTests.swift in Sources */, 885FE23F1DC51B86009CE2B4 /* IGTestObject.m in Sources */, - F1ED68B929E9B3B9003744F8 /* IGListSingleSectionControllerTests.m in Sources */, F1855A4D29BC565600558D18 /* IGListDiffDescriptionStringTests.m in Sources */, 828540511DE40D2D00118B94 /* IGListTestAdapterHorizontalDataSource.m in Sources */, 885FE2371DC51B76009CE2B4 /* IGListWorkingRangeHandlerTests.m in Sources */, @@ -2670,7 +2670,7 @@ GCC_WARN_UNINITIALIZED_AUTOS = YES_AGGRESSIVE; GCC_WARN_UNUSED_FUNCTION = YES; GCC_WARN_UNUSED_VARIABLE = YES; - IPHONEOS_DEPLOYMENT_TARGET = 11.0; + IPHONEOS_DEPLOYMENT_TARGET = 12.0; MACOSX_DEPLOYMENT_TARGET = 10.13; MTL_ENABLE_DEBUG_INFO = YES; ONLY_ACTIVE_ARCH = YES; @@ -2681,7 +2681,7 @@ ); SDKROOT = iphoneos; TARGETED_DEVICE_FAMILY = "1,2"; - TVOS_DEPLOYMENT_TARGET = 11.0; + TVOS_DEPLOYMENT_TARGET = 12.0; VERSIONING_SYSTEM = "apple-generic"; VERSION_INFO_PREFIX = ""; }; @@ -2733,7 +2733,7 @@ GCC_WARN_UNINITIALIZED_AUTOS = YES_AGGRESSIVE; GCC_WARN_UNUSED_FUNCTION = YES; GCC_WARN_UNUSED_VARIABLE = YES; - IPHONEOS_DEPLOYMENT_TARGET = 11.0; + IPHONEOS_DEPLOYMENT_TARGET = 12.0; MACOSX_DEPLOYMENT_TARGET = 10.13; MTL_ENABLE_DEBUG_INFO = NO; OTHER_CFLAGS = "-fmodules"; @@ -2745,7 +2745,7 @@ SWIFT_COMPILATION_MODE = wholemodule; SWIFT_OPTIMIZATION_LEVEL = "-O"; TARGETED_DEVICE_FAMILY = "1,2"; - TVOS_DEPLOYMENT_TARGET = 11.0; + TVOS_DEPLOYMENT_TARGET = 12.0; VALIDATE_PRODUCT = YES; VERSIONING_SYSTEM = "apple-generic"; VERSION_INFO_PREFIX = ""; diff --git a/IGListKit.xcodeproj/xcshareddata/xcschemes/IGListKit-macOS.xcscheme b/IGListKit.xcodeproj/xcshareddata/xcschemes/IGListKit-macOS.xcscheme index 1b6055721..3d5f5fa54 100644 --- a/IGListKit.xcodeproj/xcshareddata/xcschemes/IGListKit-macOS.xcscheme +++ b/IGListKit.xcodeproj/xcshareddata/xcschemes/IGListKit-macOS.xcscheme @@ -1,6 +1,6 @@