Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem configuring custom rules in pre-commit. #432

Open
eugenenelou opened this issue Mar 14, 2024 · 0 comments
Open

Problem configuring custom rules in pre-commit. #432

eugenenelou opened this issue Mar 14, 2024 · 0 comments

Comments

@eugenenelou
Copy link

eugenenelou commented Mar 14, 2024

Hello, I have written some custom rules and have them working when running fixit directly,

but they are not run by the pre-commit. The setup is that the python code is in a backend/ directory, including the pyproject.toml configuring fixit, and the directory containing the custom rules.

I tried copying the [tool.fixit] in a pyproject.toml file at the root of the repository, but it's not working either.

using versions:

  • fixit 2.1.0
  • pre-commit: 3.6.2

Edit: it seems actually that the problem is that the fixit fix --automatic command does not return a non-zero code if there are still changes, the fixit lint actually works for this. But I'd prefer to run fixit fix in pre-commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant