Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove locks from KeyBundle #108

Open
jschlyter opened this issue Feb 25, 2022 · 4 comments
Open

Remove locks from KeyBundle #108

jschlyter opened this issue Feb 25, 2022 · 4 comments
Assignees
@jschlyter
Labels
bug enhancement

Comments

@jschlyter
Copy link
Contributor

In production systems it turns out readerwriter locks sometimes ends up trying to release locks multiple times. It would help a lot if we could make KeyBundle thread safe without the use of locks.
@jschlyter jschlyter self-assigned this Feb 25, 2022
@rohe
Copy link
Contributor

rohe commented Feb 25, 2022 •
edited
Loading

Agree! I don't have any proposal right now. If I come up with something I'll let you know.

@jschlyter
Copy link
Contributor Author

jschlyter commented Feb 25, 2022 •
edited
Loading

Reading the code for KeyBundle there seems to be some wrong assumptions, e.g. that arrays are copied by value and not reference.

@rohe
Copy link
Contributor

rohe commented Feb 25, 2022

Agree, should be fixed. You or me ?

@jschlyter jschlyter mentioned this issue Feb 25, 2022
Merged
@jschlyter
Copy link
Contributor Author

I've started in #110. To remove the locks, we could begin with the read locks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jschlyter jschlyter

Labels
bug enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jschlyter @rohe