Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node minimum version #21

Open
XaveScor opened this issue Jul 15, 2024 · 2 comments
Open

Node minimum version #21

XaveScor opened this issue Jul 15, 2024 · 2 comments

Comments

@XaveScor
Copy link

Vitest supports node>=18 only, but vitest-fetch-mock supports node 14 in package.json.

https://github.com/vitest-dev/vitest/blob/d7b0387125da9c2882b12a1f63cc693dc049b15c/package.json#L9

I think, we can safely up the minimum supported Node version up to v18. It allows the lib to use the native fetch instead of cross-fetch polyfill.

@IanVS
Copy link
Owner

IanVS commented Jul 15, 2024

Ah, yes, my intention was to support node 18+, I just didn't notice I had an engines field. Would you like to submit a PR?

@XaveScor
Copy link
Author

I'll make a PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants