Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not all OutputEvents are exposed as Ports in MultiDynamics #33

Open
tclose opened this issue Jan 13, 2018 · 1 comment
Open

Not all OutputEvents are exposed as Ports in MultiDynamics #33

tclose opened this issue Jan 13, 2018 · 1 comment
Labels
bug

Comments

@tclose
Copy link
Contributor

tclose commented Jan 13, 2018

Not all OutputEvents are necessarily exposed as Ports in MultiDynamics objects. However, this is checked for in the Dynamics init method (L171 nineml/abstraction/dynamics/base.py). So really we should just check that all declared output event ports are in the list of inferred ports, not that the declared list is identical to the inferred one.
@tclose tclose added the bug label Jan 13, 2018
@tclose
Copy link
Contributor Author

tclose commented Apr 14, 2020

NB: output ports are "inferred" from output events

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tclose