-
-
Notifications
You must be signed in to change notification settings - Fork 532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to homebrew-core for Linux #566
Comments
2 is already done, see: https://formulae.brew.sh/formula/php |
@SMillerDev somewhat but I think it could be cleaned up. It still references "Bottle (binary package) installation support provided for macOS releases:" and then goes on to list Linux in there. I think Linux support would ideally be a separate table or at least use a different prefix. |
I am interested in doing at least some of this, so I'll try to carve out time. With packing and moving house in the next few weeks I'm not sure how much time is left. |
Awesome thanks @issyl0 🎉 |
☝️Same for me. |
This seems to have already happened: a30c1b1. The links and textual references however still need updating, though that'll be handled by deleting the Linux specific pages. |
I've got time today to work on some of this but I don't want to duplicate work other people are doing (or take it from them). @issyl0, are there any parts of this that you're not working on that you would like some help with? |
@Rylan12 Figuring out how we'd use |
This seems like a good spot for a shameless plug of my Liquid language module for BBEdit 😃 |
Since each formula's JSON file will need to also contain the Linux statistics from its correpsonding formula-linux JSON file, I'm going to assume tacking them on as an |
@EricFromCanada makes sense for me! |
Isn't nr. 3 done by @Rylan12 for the Homebrew API? |
@SMillerDev unsure! |
I think the HTML pages still need updating at least. |
☝️ Updating the Liquid templates is on my list |
The only part that I know has not been updated in the json files yet are macOS version differences for casks. We haven't fully removed the old |
Which page is # 3? |
Any page with "Linux/macOS dependencies, analytics (and perhaps: caveats, anything else?)" |
Ok. Is it referring to having a separate table for formulae that are macOS-only, and another table for the ones that are Linux-only? |
That sounds like it wouldn't work for the vast majority of formulae that support both macOS and Linux |
@osalbahr @SMillerDev I think the ideal outcome would be:
For a relatively simple example, check out the (truncated, relevant) output from [
{
"build_dependencies": [
"pkg-config"
],
"dependencies": [
"libidn2",
"openssl@3"
],
"test_dependencies": [],
"recommended_dependencies": [],
"optional_dependencies": [],
"head_dependencies": {
"build_dependencies": [
"autoconf",
"automake",
"xz",
"pkg-config"
],
"dependencies": [
"gettext",
"libidn2",
"openssl@3"
],
"test_dependencies": [],
"recommended_dependencies": [],
"optional_dependencies": [],
"uses_from_macos": [],
"uses_from_macos_bounds": []
},
"variations": {
"x86_64_linux": {
"dependencies": [
"libidn2",
"openssl@3",
"util-linux"
],
"head_dependencies": {
"build_dependencies": [
"autoconf",
"automake",
"xz",
"pkg-config"
],
"dependencies": [
"gettext",
"libidn2",
"openssl@3",
"util-linux"
],
"test_dependencies": [],
"recommended_dependencies": [],
"optional_dependencies": [],
"uses_from_macos": [],
"uses_from_macos_bounds": []
}
}
},
"name": "wget"
}
] You can notice here there's essentially 3 configurations we care about (for dependencies):
so this would be either 1 additional table (for Linux) on https://formulae.brew.sh/formula/wget with something like "Depends on (Linux): Make sense? |
I was trying to propose 3 tables in https://formulae.brew.sh/analytics/install/30d/.
Oh, I see. I was looking at the wrong website maybe (hence my original question). If this is about dependency information, then yeah I think qualifying with “Depends on (Linux) :” is better than having a separate table but both seem fine. |
I've removed the analytics mention from the original issue body, there's no real need to have separation there.
👍🏻 |
We've now migrated Linux formulae from linuxbrew-core to homebrew-core. Unfortunately, this breaks a non-trivial number of assumptions in this codebase.
Things that need to be updated (in a rough order, combining/jumping steps is fine):
keg_only
/ deprecated / disabled status, and (possibly) caveat textredirect_from
plugin to ensure that we don't break any links that used to work (e.g. migrate API JSON, formula/analytics/index pages)Things that don't need updating:
CC @EricFromCanada @Rylan12 @issyl0 for folks who have done Linux work here previously and may be interested in volunteering ❤️
The text was updated successfully, but these errors were encountered: