Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

option to remove BrewTestBot checked formulae from brew livecheck output #18640

Open
1 task done
eleanordoesntcode opened this issue Oct 26, 2024 · 5 comments · May be fixed by #18984
Open
1 task done

option to remove BrewTestBot checked formulae from brew livecheck output #18640

eleanordoesntcode opened this issue Oct 26, 2024 · 5 comments · May be fixed by #18984
Labels
features New features help wanted We want help addressing this

Comments

@eleanordoesntcode
Copy link

Verification

Provide a detailed description of the proposed feature

An option to remove formulaes BrewTestBot check automatically from the output of brew livecheck. The command could verify if the formulae is in the list of formulaes that are checked by BrewTestBot before even sending a network request, to preserve on time wasted on checking formulaes that are automatically updated.

What is the motivation for the feature?

This would preserve time on contributors like me, who want to help updating formulaes by running brew livecheck --newer-only --eval-all but don't want to spend time checking if the formulae is handled by BrewTestBot, since 80-90% of the formulaes outputed by this command are in the list.

How will the feature be relevant to at least 90% of Homebrew users?

It won't be relevant to anybody who doesn't contribute to Homebrew, but for those who do, it would save quite some time.

What alternatives to the feature have been considered?

A bash script can be made to only print a line of brew livecheck if the first word isn't in the BrewTestBot checked formulae list, but this is hacky and it might break.

@eleanordoesntcode eleanordoesntcode added the features New features label Oct 26, 2024
@carlocab carlocab added the help wanted We want help addressing this label Oct 26, 2024
@gromgit
Copy link
Member

gromgit commented Oct 26, 2024

By "BrewTestBot checked formulae", do you mean autobumped formula? If so, there's a one-liner to avoid live checking them at all:

comm -23 <(brew formulae | grep -v /) $(brew --repo homebrew/core)/.github/autobump.txt | xargs brew livecheck --formulae --newer-only

@MikeMcQuaid
Copy link
Member

This would preserve time on contributors like me, who want to help updating formulaes by running brew livecheck --newer-only --eval-all but don't want to spend time checking if the formulae is handled by BrewTestBot, since 80-90% of the formulaes outputed by this command are in the list.

Just to confirm I understand @eleanordoesntcode: is it that this command will still attempt to check the livecheck status for formulae it later complains about being handled by BrewTestBot and you'd rather they were skipped entirely?

If so: it kinda feels like this should be the default behaviour for end-users and we should instead be passing an argument/environment variable when running this in CI or in local live check testing to do otherwise.

@eleanordoesntcode
Copy link
Author

eleanordoesntcode commented Oct 26, 2024

By "BrewTestBot checked formulae", do you mean autobumped formula? If so, there's a one-liner to avoid live checking them at all:

comm -23 <(brew formulae | grep -v /) $(brew --repo homebrew/core)/.github/autobump.txt | xargs brew livecheck --formulae --newer-only

I did mean that yes.
Thanks for the one liner, but I'd prefer if it was directly built in instead of having to resort to this. The code resulting would be more stable than something that might break.

@eleanordoesntcode
Copy link
Author

eleanordoesntcode commented Oct 26, 2024

This would preserve time on contributors like me, who want to help updating formulaes by running brew livecheck --newer-only --eval-all but don't want to spend time checking if the formulae is handled by BrewTestBot, since 80-90% of the formulaes outputed by this command are in the list.

Just to confirm I understand @eleanordoesntcode: is it that this command will still attempt to check the livecheck status for formulae it later complains about being handled by BrewTestBot and you'd rather they were skipped entirely?

Yes, the command will return formulaes that aren't bumped even though they're autobumped by BrewTestBot for the most part.

@MikeMcQuaid
Copy link
Member

@eleanordoesntcode Thanks for explaining! I think this would be ideally default behaviour, then.

@issyl0 issyl0 linked a pull request Dec 22, 2024 that will close this issue
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
features New features help wanted We want help addressing this
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants