Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actions lacking tests #549

Open
Bo98 opened this issue Jun 2, 2024 · 1 comment
Open

Actions lacking tests #549

Bo98 opened this issue Jun 2, 2024 · 1 comment
Labels
help wanted Extra attention is needed

Comments

@Bo98
Copy link
Member

Bo98 commented Jun 2, 2024

(Extracted from #542)

The following actions are lacking tests and thus we are currently blindly merging changes to:

Action Status Recommendation Status
bump-formulae Deprecated but stable.
Any bump-package test coverage would cover this one
Add tests to bump-packages
bump-packages Composite action. No tests Figure out how to test this
create-gcloud-instance Shell scripts. No tests @Bo98 will deprecate this soon
failures-summary-and-bottle-result Composite action. No tests Figure out how to test this
find-related-workflow-run-id Uses gh. No tests Migrate this to use octokit.js #590
limit-pull-requests Uses gh. No tests Migrate this to use octokit.js #589
post-build
pre-build
Composite action. No tests.
Probably the most actively maintained in this list
Move this to homebrew-core,
which already has CI coverage
remove-disabled-packages Uses Ruby, executes commands. No tests Figure out how to test this
wait-for-idle-runner Can easily be added to the Node test suite
but isn't expected to stay around for long
@Bo98 will deprecate this soon

Node.js tests are preferred (see *.test.mjs files) as it links with Codecov.
Dedicated test workflows (like setup-homebrew) are acceptable if Node.js tests are demonstrated to not be possible/feasible (e.g. things written in pure shell that don't benefit from porting to JS, such as bump-packages). Any such test workflows however should not require any write tokens or secrets.

@Bo98 Bo98 added the help wanted Extra attention is needed label Jun 2, 2024
@MikeMcQuaid
Copy link
Member

Thanks for opening this @Bo98!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants