Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance mode should free resources #264

Open
tazlin opened this issue Aug 26, 2024 · 1 comment
Open

Maintenance mode should free resources #264

tazlin opened this issue Aug 26, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@tazlin
Copy link
Member

tazlin commented Aug 26, 2024

There are a couple of possible approaches to this:

  1. The worker simply instructs all ComfyUI processes to unload models using the usual mechanisms (UNLOAD_MODELS_FROM_RAM message).
    • This has the side effect of retaining ~200mb of RAM per process
    • The safety process does not currently have an unload mechanism. Either one would be need to be implemented, or the safety process could alternatively be stopped - which would require the worker not attempt to automatically restart it as is currently the case.
  2. The worker shuts down all sub-processes, including the safety process.
    • It may be sufficient to shut all but one inference process and unload it's models, which would reduce ramp up time once maintenance mode is cleared.
    • Again, the worker would need a flag to avoid reloading these halted processes once they are halted for maintenance.
@tazlin tazlin added the enhancement New feature or request label Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants
@tazlin and others