Skip to content
This repository has been archived by the owner on Mar 29, 2022. It is now read-only.

Ensure CI fails if network requests are made #436

Open
johndbritton opened this issue Nov 12, 2019 · 2 comments
Open

Ensure CI fails if network requests are made #436

johndbritton opened this issue Nov 12, 2019 · 2 comments
Labels
environment Development, test, CI, deployment, and related issues help-wanted Looking for help from open source contributors

Comments

@johndbritton
Copy link
Contributor

johndbritton commented Nov 12, 2019 •
edited
Loading

We have VCR to record network requests in tests. CI should fail if a network request is made. It should not record a new cassette.
@johndbritton johndbritton added help-wanted Looking for help from open source contributors environment Development, test, CI, deployment, and related issues labels Nov 12, 2019
@edimossilva
Copy link

Can I work on this issue?

@MattIPv4
Copy link
Member

MattIPv4 commented Oct 9, 2020

Go for it 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
environment Development, test, CI, deployment, and related issues help-wanted Looking for help from open source contributors
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@johndbritton @edimossilva @MattIPv4