Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reactdatepicker.com shows blank page #5108

Open
ilkou opened this issue Sep 22, 2024 · 16 comments
Open

reactdatepicker.com shows blank page #5108

ilkou opened this issue Sep 22, 2024 · 16 comments

Comments

@ilkou
Copy link
Contributor

ilkou commented Sep 22, 2024

Describe the bug
The official website is down, it shows a blank page! I've attached a screenshot of the console error

Screenshots
Screenshot 2024-09-22 at 19 59 54

@ryanadhi
Copy link

I am experiencing the same thing

1 similar comment
@velo-kim
Copy link

I am experiencing the same thing

@piyushimraw
Copy link

I am experienceing same

@manoushka
Copy link

same here

1 similar comment
@johannrp27
Copy link

same here

@martijnrusschen
Copy link
Member

Locally it's working fine, it seems somewhere in the build step things may be going wrong. Is anyone able to look into this?

@johannrp27
Copy link

I just have downloaded the repo to play locally: yarn, yarn build and lastly yarn start. Still not working.

image

@BruceHubbard
Copy link

When I run this locally I get the same format error. Looks like for this import:

import { format, longFormatters } from "date-fns/format";

ends up now with format being undefined. Looks like date-fns just got updated so I'm guessing it's from that. Probably some breaking change in 4.0 that isn't handled.

@martijnrusschen
Copy link
Member

@BruceHubbard Nice find, here's the PR that upgraded date-fns: #5102

@martijnrusschen
Copy link
Member

@BruceHubbard what happens if you change this to import { format, longFormatters } from "date-fns"; Looking at the date-fns readme that's how they do the import.

@johannrp27
Copy link

How come that update got there? If the diff between v7.3 and v7.4 was just a minor of date-fns

@martijnrusschen
Copy link
Member

The docs site is running from the master version of the Datepicker. So it's slightly ahead of the v7.4 version.

@johannrp27
Copy link

Nice, I just downgrade date-fns from v4 to v3 and everything is working now, so that's the issue.
As @BruceHubbard said it's a good clue. I did try to find every format and replace it with the import suggested but still not working. I'll keep searching

@martijnrusschen
Copy link
Member

@johannrp27 ok thank you! What I can do:

  1. revert the upgrade to bring back the site
  2. once you've found the fix, you can include the upgrade in the PR

@martijnrusschen
Copy link
Member

martijnrusschen commented Sep 25, 2024

Revert is merged, https://reactdatepicker.com is back alive! Now, let's figure out how we can make this upgrade work :)

@BruceHubbard
Copy link

Thanks Martjin for the quick fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants